Configure -optl-static via feature flag
#1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
This was referenced Aug 14, 2020
mboes
approved these changes
Aug 17, 2020
TerrorJack
force-pushed
the
allow-files
branch
from
e99df66
to
db5e077
Compare
|
How bizarre. The force-push notification above attributes it to @TerrorJack, when it's likely from @aherrmann... |
It's the rebase from mergify. For some reason mergify attributes that to some random user (random as in I don't know what determines it). For a while it was @mboes, e.g. here, recently it switched to being @TerrorJack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1408 this replaces the need to configure
compiler_flagsdirectly by settingfeatures = ["fully_static_link"]to configure a fully statically linked binary. This does not yet address how to configure fully static linking for binaries generated bystack_snapshot. However, configuring the feature flag globally via the command-line flag--features fully_static_linkwill already produce fully statically linkedstack_snapshotbinaries.