Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define Bazel version in one shared location #1252

Merged
merged 3 commits into from
Feb 25, 2020
Merged

Define Bazel version in one shared location #1252

merged 3 commits into from
Feb 25, 2020

Commits on Feb 25, 2020

  1. Define Bazel version in one shared location 

    Instead of each CI pipeline separately defining the Bazel version, we
define it in one shared location `.ci/bazelversion`. Ideally, we would
use `.bazelversion` in the top-level which would be compatible with
[bazelisk](https://github.com/bazelbuild/bazelisk). Unfortunately, this
is incompatible with the way Bazel is packaged in nixpkgs right now.
See, `.ci/check-bazel-version`.

The pipelines that use nixpkgs to provision Bazel check that the Bazel
version matches using `.ci/check-bazel-version`. The pipelines that
fetch a Bazel binary distribution use `.ci/fetch-bazel-bindist` which in
turn consults the `.ci/bazelversion` file. To avoid issues with
corrupted downloads we check the downloaded bindist against expected
sha256 hashes defined in `.ci/bazel-sha256`.

The files `.ci/bazelversion` and `.ci/bazel-sha256` need to be kept in
sync. The script `.ci/update-bazel-version` helps with this. Given a
Bazel version number it will update both files. The nixpkgs revision
needs to be updated separately. The `MAINTAINERS.md` file has been
updated accordingly.
    @aherrmann
    aherrmann authored and mergify-bot committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    f6b6e52 View commit details
    Browse the repository at this point in the history

  2. Netlify's sha256 does not support --ignore-missing 

    To work around this we store separate `.sha256` files for each platform.
    @aherrmann
    aherrmann authored and mergify-bot committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    39b10c8 View commit details
    Browse the repository at this point in the history

  3. Fix sha256sum issue on Windows 

    git was automatically converting `\n` lineendings to `\r\n`, which
confused `sha256sum`. By declaring `.sha256` files as binary
`.gitattributes` we avoid this issue.
    @aherrmann
    aherrmann authored and mergify-bot committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    2a297e7 View commit details
    Browse the repository at this point in the history