WIP bazelci: fix initial build errors #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profpatsch
force-pushed
the
bazelci-fix-initial-build-errors
branch
4 times, most recently
from
31971f9 to
7b5d183
Compare
Profpatsch
force-pushed
the
bazelci-fix-initial-build-errors
branch
12 times, most recently
from
5a97c09 to
a89286d
Compare
`C.UTF-8` is a locale supported by [fairly recent glibc](https://sourceware.org/glibc/wiki/Proposals/C.UTF-8) and is the same as the default `C` locale, but with the following differences: * LC_IDENTIFICATION: Mentioned for completeness * LC_COLLATE: Sort using the Unicode codepoint * LC_CTYPE: UTF-8 encoding The big advantage this gives us is that we don’t implicitely require a locale_archive to exist on the system. This is especially handy for e.g. minimal containers that don’t provide a locale archive (e.g. on CI).
Profpatsch
force-pushed
the
bazelci-fix-initial-build-errors
branch
from
a89286d to
27d673f
Compare
aherrmann
reviewed
Sep 16, 2019
Profpatsch
force-pushed
the
bazelci-fix-initial-build-errors
branch
from
27d673f to
3138ea1
Compare
|
Hm, now of course the Windows test is failing. I’ll revert to not exiting when a file is missing. |
`readelf` behaves differently depending on which package it comes from. Let’s hope `find` doesn’t. Parsing the output is hacky, but this is just a test so we will notice if it fails somewhere.
Profpatsch
force-pushed
the
bazelci-fix-initial-build-errors
branch
from
3138ea1 to
18b88f7
Compare
This was referenced Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting https://buildkite.com/bazel/rules-haskell-haskell/ to pass.