Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Plutarch 1.3 #4

Merged
merged 9 commits into from
Nov 3, 2022
Merged

Support Plutarch 1.3 #4

merged 9 commits into from
Nov 3, 2022

Conversation

Niols
Copy link
Member

@Niols Niols commented Nov 2, 2022

No description provided.

@Niols Niols requested a review from gabrielhdt November 2, 2022 14:00
@Niols Niols self-assigned this Nov 2, 2022
@Niols
Copy link
Member Author

Niols commented Nov 2, 2022

For now, it does not work and fails while compiling cardano-crypto-class. It yields:

cardano-crypto-class-lib-cardano-crypto-class> [45 of 48] Compiling Cardano.Crypto.KES.Simple ( src/Cardano/Crypto/KES/Simple.hs, dist/build/Cardano/Crypto/KES/Simple.o, dist/build/Cardano/Crypto/KES/Simple.dyn_o )
cardano-crypto-class-lib-cardano-crypto-class> src/Cardano/Crypto/KES/Simple.hs:195:10: error:
cardano-crypto-class-lib-cardano-crypto-class>     • Could not deduce (NoThunks (Vector (SignKeyDSIGN d)))
cardano-crypto-class-lib-cardano-crypto-class>         arising from a use of ‘NoThunks.Class.$dmwNoThunks’
cardano-crypto-class-lib-cardano-crypto-class>       from the context: DSIGNAlgorithm d
cardano-crypto-class-lib-cardano-crypto-class>         bound by the instance declaration
cardano-crypto-class-lib-cardano-crypto-class>         at src/Cardano/Crypto/KES/Simple.hs:195:10-66
cardano-crypto-class-lib-cardano-crypto-class>     • In the expression:
cardano-crypto-class-lib-cardano-crypto-class>         NoThunks.Class.$dmwNoThunks @(SignKeyKES (SimpleKES d t))
cardano-crypto-class-lib-cardano-crypto-class>       In an equation for ‘NoThunks.Class.wNoThunks’:
cardano-crypto-class-lib-cardano-crypto-class>           NoThunks.Class.wNoThunks
cardano-crypto-class-lib-cardano-crypto-class>             = NoThunks.Class.$dmwNoThunks @(SignKeyKES (SimpleKES d t))
cardano-crypto-class-lib-cardano-crypto-class>       In the instance declaration for
cardano-crypto-class-lib-cardano-crypto-class>         ‘NoThunks (SignKeyKES (SimpleKES d t))’
cardano-crypto-class-lib-cardano-crypto-class>     |
cardano-crypto-class-lib-cardano-crypto-class> 195 | instance DSIGNAlgorithm d => NoThunks (SignKeyKES (SimpleKES d t))
cardano-crypto-class-lib-cardano-crypto-class>     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
cardano-crypto-class-lib-cardano-crypto-class> src/Cardano/Crypto/KES/Simple.hs:196:10: error:
cardano-crypto-class-lib-cardano-crypto-class>     • Could not deduce (NoThunks (Vector (VerKeyDSIGN d)))
cardano-crypto-class-lib-cardano-crypto-class>         arising from a use of ‘NoThunks.Class.$dmwNoThunks’
cardano-crypto-class-lib-cardano-crypto-class>       from the context: DSIGNAlgorithm d
cardano-crypto-class-lib-cardano-crypto-class>         bound by the instance declaration
cardano-crypto-class-lib-cardano-crypto-class>         at src/Cardano/Crypto/KES/Simple.hs:196:10-66
cardano-crypto-class-lib-cardano-crypto-class>     • In the expression:
cardano-crypto-class-lib-cardano-crypto-class>         NoThunks.Class.$dmwNoThunks @(VerKeyKES (SimpleKES d t))
cardano-crypto-class-lib-cardano-crypto-class>       In an equation for ‘NoThunks.Class.wNoThunks’:
cardano-crypto-class-lib-cardano-crypto-class>           NoThunks.Class.wNoThunks
cardano-crypto-class-lib-cardano-crypto-class>             = NoThunks.Class.$dmwNoThunks @(VerKeyKES (SimpleKES d t))
cardano-crypto-class-lib-cardano-crypto-class>       In the instance declaration for
cardano-crypto-class-lib-cardano-crypto-class>         ‘NoThunks (VerKeyKES (SimpleKES d t))’
cardano-crypto-class-lib-cardano-crypto-class>     |
cardano-crypto-class-lib-cardano-crypto-class> 196 | instance DSIGNAlgorithm d => NoThunks (VerKeyKES  (SimpleKES d t))
cardano-crypto-class-lib-cardano-crypto-class>     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
cardano-crypto-class-lib-cardano-crypto-class> [46 of 48] Compiling Cardano.Crypto.KES.CompactSingle ( src/Cardano/Crypto/KES/CompactSingle.hs, dist/build/Cardano/Crypto/KES/CompactSingle.o, dist/build/Cardano/Crypto/KES/CompactSingle.dyn_o )
cardano-crypto-class-lib-cardano-crypto-class> [47 of 48] Compiling Cardano.Crypto.KES.CompactSum ( src/Cardano/Crypto/KES/CompactSum.hs, dist/build/Cardano/Crypto/KES/CompactSum.o, dist/build/Cardano/Crypto/KES/CompactSum.dyn_o )
error: builder for '/nix/store/055jbma4m9k5y3z1kmqf6591p5i3s1xm-cardano-crypto-class-lib-cardano-crypto-class-2.0.0.1.drv' failed with exit code 1;
       last 10 log lines:
       >       In an equation for ‘NoThunks.Class.wNoThunks’:
       >           NoThunks.Class.wNoThunks
       >             = NoThunks.Class.$dmwNoThunks @(VerKeyKES (SimpleKES d t))
       >       In the instance declaration for
       >         ‘NoThunks (VerKeyKES (SimpleKES d t))’
       >     |
       > 196 | instance DSIGNAlgorithm d => NoThunks (VerKeyKES  (SimpleKES d t))
       >     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       > [46 of 48] Compiling Cardano.Crypto.KES.CompactSingle ( src/Cardano/Crypto/KES/CompactSingle.hs, dist/build/Cardano/Crypto/KES/CompactSingle.o, dist/build/Cardano/Crypto/KES/CompactSingle.dyn_o )
       > [47 of 48] Compiling Cardano.Crypto.KES.CompactSum ( src/Cardano/Crypto/KES/CompactSum.hs, dist/build/Cardano/Crypto/KES/CompactSum.o, dist/build/Cardano/Crypto/KES/CompactSum.dyn_o )
       For full logs, run 'nix log /nix/store/055jbma4m9k5y3z1kmqf6591p5i3s1xm-cardano-crypto-class-lib-cardano-crypto-class-2.0.0.1.drv'.

@andreabedini
Copy link
Collaborator

andreabedini commented Nov 3, 2022

@Niols if I rememeber correctly cardano-crypto-class is missing an upper bound on vector.

Add the following to your cabal.project

constraints:
 -- cardano-crypto-class-2.0.0.1 needs
 vector < 0.13

Actually, it's a bit more subtle input-output-hk/nothunks#17

Copy link
Contributor

@gabrielhdt gabrielhdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've simplified everything, and reset that repo back to a genuine "hello-plutarch" (the lotto stuff has been moved to scverif). IMO we can merge that, and then consolidate by providing a readme and a ci.

@Niols Niols marked this pull request as ready for review November 3, 2022 11:49
@Niols
Copy link
Member Author

Niols commented Nov 3, 2022

Yup, I do think it looks good and we should just merge this then iterate from there. There is still a conflict preventing the merge. I can take care of that later today.

@gabrielhdt gabrielhdt merged commit 713c292 into main Nov 3, 2022
@gabrielhdt gabrielhdt deleted the plutarch-1.3 branch November 3, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants