Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github workflow plus some cleanups #3

Merged
merged 10 commits into from
Jan 25, 2022
Merged

Conversation

facundominguez
Copy link
Member

No description provided.

Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Minor comment, otherwise LGTM.

- [ ] Implement tests
- [ ] Setup CI
- [X] Have himportscan support lhs files
- [ ] Move the update-repos feature of gazelle\_cabal to gazelle\_haskell\_modules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the open ones done already, or if not have corresponding GH issues?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keeping track of the ones that are still relevant, and I hope to resolve them this week.

.github/workflows/workflow.yaml Outdated Show resolved Hide resolved
@facundominguez
Copy link
Member Author

By chance, do you know how can we get rid of the mergify check?

@aherrmann
Copy link
Member

By chance, do you know how can we get rid of the mergify check?

No, I'm not sure why it's there in the first place.

@facundominguez facundominguez merged commit f5bf60c into main Jan 25, 2022
@facundominguez facundominguez deleted the fd/workflow branch January 25, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants