chore: use tweag/run-nix-shell
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrindel
force-pushed
the
cg/run-nix-shell
branch
from
9b5c9f6
to
a37f660
Compare
avdv
reviewed
Dec 13, 2023
| run: | | ||
| bazel run //:gazelle --config=${{ matrix.ghc-version }} | ||
| bazel run //:gazelle-update-repos --config=${{ matrix.ghc-version }} | ||
| bazel test //... --config=${{ matrix.ghc-version }} |
There was a problem hiding this comment.
I think we should add set -e here, to make the shell exit immediately when the gazelle commands fail. Maybe we could even make this the default in the run-nix-shell action? Github's run step passes --noprofile --norc -eo pipefail to bash by default.
There was a problem hiding this comment.
I will add the set -e. I agree about having run-nix-shell add certain shell flags. I will add this in a subsequent PR.
avdv
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/tweag/scalable-builds-group/issues/138.