Update to latest Plutus #42

VictorCMiraldo · 2021-12-08T13:04:17Z

While looking into issue #37, and understanding that those checks were merged on verion v2021-12-06 of plutus-apps, I attempted to update our cabal file following our process in the readme file (which worked last time!), only to be met with a compilation error within plutus-tx-plugin, which is a library from within plutus:

src/PlutusTx/Compiler/Expr.hs:775:41: error:
    Not in scope: type constructor or class `GHC.GenTickish'
    Perhaps you meant one of these:
      `GHC.Tickish' (imported from GhcPlugins),
      `GHC.Tickish' (imported from CoreSyn)
    Neither `Class', `CoreSyn', `CostCentre', `FV', `GhcPlugins',
            `MkId' nor `PrelNames' exports `GenTickish'.
    |
775 | getSourceSpan :: Maybe GHC.ModBreaks -> GHC.GenTickish pass -> Maybe GHC.RealSrcSpan
    |                                         ^^^^^^^^^^^^^^
cabal: Failed to build plutus-tx-plugin-0.1.0.0 (which is required by
test:spec from cooked-validators-0.0.0). See the build log above for details.

After a long odyssey and with a lot of help from Cheng and Adrian, I managed to get a nix enviroment that builds everything I need and enables me to build plutus and the necessary dev tooling.

@GuillaumeDesforges , I'd love your review of the nix files in this PR, since you were the person to help get this going in the first place. Because we had to build haskell-language-server with a custom patch to ghcide and with a custom ghc, I tried to split my dependencies into development deps and build deps. HLS is a dev-dep, and CI should not worry about it. I hope I did this in a reasonable way. :)

… My nix shell is now attempting to build ghc 9.0.1 and I have no idea why.

… to it

…ent version but nix insists on building 1.5.0.1

…you Cheng

…nMinAda', which is awesome!

CI

…utus-update

…match that of Plutus

…xO feature raises serious concerns. I think this will have to be reimplemented differently within plutus

most notably awaitTime had an off-by-one error; we must wait until the slot that contains time t, and then another slot to be sure we return in a time that is in the future of t.

useful error information and respect newlines

othewise we'd trivially get a 'ValueNotPreserved' error

* Rewrite balancing in terms of BalancableOut class * Start working on balance tests themselves * Describe spendValueFrom * Add some more tests on balancespec * Update and fix balance tests

0xd34df00d

LGTM with a couple of tiny notes.

cooked-validators/src/Cooked/MockChain/Monad.hs

* Remove the MarkedMaker and its tests; at the end of the day, the features used around it are all exemplified elsewhere * Ported the datum hijacking attack to PMultiSigStateful

Co-authored-by: 0xd34df00d <[email protected]>

Victor Miraldo added 2 commits December 8, 2021 09:56

Attempt a plutus update

4052950

Trying plutus update

f8a3eb8

VictorCMiraldo added the help wanted Extra attention is needed label Dec 8, 2021

Victor Miraldo added 5 commits December 8, 2021 14:30

Attempt to use haskell.nix, no success

50dd88f

Try bringing in the ghc version we need from haskell-nix, no success.…

b87fe2f

… My nix shell is now attempting to build ghc 9.0.1 and I have no idea why.

This is more promising!

86fa829

Got hlint

504129c

I think we've got it! Thanks Cheng!

5df9736

VictorCMiraldo changed the title ~~WIP: Attempt to update to latest plutus; need help with nix and ghc versions~~ Update to latest Plutus Dec 8, 2021

Victor Miraldo added 8 commits December 8, 2021 18:20

Nah, we need a custom ghcide too; I just don't know how to pass flags…

0e0e3c0

… to it

Discovered configureArgs; didn't fix anything. Trid building a differ…

e0f7dce

…ent version but nix insists on building 1.5.0.1

Still trying to build the wrong version

4ad845d

Nope... older version still has the same issue

63e0c1b

Houston, we have liftoff! Finally managed to get HLS working, thanks …

6d9bb11

…you Cheng

Comments to shell-nix; add the needed patch

1063989

Fix build of cooked-validators

a7c50e1

Fix deps of examples; all our tests fail due to 'ValueContainsLessTha…

6c27809

…nMinAda', which is awesome!

VictorCMiraldo removed the help wanted Extra attention is needed label Dec 9, 2021

Victor Miraldo added 12 commits December 9, 2021 14:01

Split our nix setup in two files to use a GH caching install action on

28bf34b

CI

Wrong version

87c6134

Try setting up binary caches in CI

c147aa0

YAML syntax error

ed2cede

Trying a different way of caching the nix env

13bdd35

Remove hls from ci dependencies

d43f81b

Move the cabal update to within nix

06ee1b4

Nix mistake

a6c9072

Merge branch 'main' of github.com:tweag/audit-plutus-libs into vcm/pl…

b9c41b0

…utus-update

Fix ForgeSpec

00e694f

Disable other tests to see CI caching in action

de815f5

cabal update outside the root

62f04b0

Victor Miraldo added 10 commits December 10, 2021 16:34

Thread a ValidateTxOpts and change the type to validateTxSkelOpts to …

87a34c1

…match that of Plutus

Try sudoing when loading the nix cache?

2903651

Again

cabe58c

Can we fool the runner?

6f531d3

temporary disable tests to test CI caching

02da9c6

Re-enable one test; lets see if caching is finally working

0d793f1

Try again

2734f06

Ok, forger about locally caching our nix store

34e3332

Merge branch 'main' into vcm/plutus-update

e2f442f

Make waiting for a tx to be optional when running in the contract monad

f4fe697

VictorCMiraldo mentioned this pull request Dec 11, 2021

Understand whether we need to check for minUTxOValue or whether the plutus code we depend does so automatically #37

Closed

Fix PMultiSigStateful; what a messgit add -u . This new minAda per UT…

4430d6e

…xO feature raises serious concerns. I think this will have to be reimplemented differently within plutus

VictorCMiraldo requested a review from 0xd34df00d December 11, 2021 11:18

VictorCMiraldo mentioned this pull request Dec 11, 2021

Understand and standardize adjustUnbalancedTx. #46

Closed

Victor Miraldo and others added 8 commits December 13, 2021 11:45

Remove two test files, lowers the maintenance burden

f6b4d7d

Fix Crowdfunding test, which trigger some bugfixes here and there;

47f17b2

most notably awaitTime had an off-by-one error; we must wait until the slot that contains time t, and then another slot to be sure we return in a time that is in the future of t.

SplitSpec is almost taken care of

d84d458

Example HUnit assertions; there has to be a better way of displaying

c6b3805

useful error information and respect newlines

Erased old suite

0af4714

The PMultiSigStatefulSpec's dupToken attack needs to be more complex;

6757d18

othewise we'd trivially get a 'ValueNotPreserved' error

Fix ForgeSpec; refactor definition of tokens out of the test file

1e91451

Balance tests (#50)

74c8563

* Rewrite balancing in terms of BalancableOut class * Start working on balance tests themselves * Describe spendValueFrom * Add some more tests on balancespec * Update and fix balance tests

0xd34df00d approved these changes Dec 17, 2021

View reviewed changes

cooked-validators/src/Cooked/MockChain/Monad.hs Outdated Show resolved Hide resolved

cooked-validators/src/Cooked/MockChain/Monad.hs Outdated Show resolved Hide resolved

0xd34df00d and others added 4 commits December 17, 2021 15:01

Minor typo fixes

73b4b94

* Remove validateTxFromSkeleton

ddc5342

* Remove the MarkedMaker and its tests; at the end of the day, the features used around it are all exemplified elsewhere * Ported the datum hijacking attack to PMultiSigStateful

Forgot to fix BalanceSpec.hs

5fb2bc1

Update cooked-validators/src/Cooked/MockChain/Monad.hs

a5285eb

Co-authored-by: 0xd34df00d <[email protected]>

VictorCMiraldo merged commit 96d2c0a into main Dec 20, 2021

VictorCMiraldo deleted the vcm/plutus-update branch December 20, 2021 14:47

VictorCMiraldo mentioned this pull request Dec 20, 2021

Having a function giving the value associated to a Spendable output would be nice #51

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to latest Plutus #42

Update to latest Plutus #42

VictorCMiraldo commented Dec 8, 2021 •

edited

Loading

0xd34df00d left a comment

Update to latest Plutus #42

Update to latest Plutus #42

Conversation

VictorCMiraldo commented Dec 8, 2021 • edited Loading

0xd34df00d left a comment

Choose a reason for hiding this comment

VictorCMiraldo commented Dec 8, 2021 •

edited

Loading