Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps for GHC 9.8, fix building with unix-2.8, update CI #420

Closed
wants to merge 3 commits into from

Conversation

andreasabel
Copy link

@andreasabel andreasabel commented Nov 12, 2023

  • inline-r/tests: Fix build error with unix-2.8.0
  • CI workflow: fix deprecation warnings, bump action versions
  • Bump dependencies for GHC 9.8, add latest stackage resolvers

Triggered by:

@andreasabel andreasabel changed the title ghc 9.8 Bumps for GHC 9.8, fix building with unix-2.8, update CI Nov 12, 2023
@facundominguez
Copy link
Member

Hello @andreasabel! Thanks for your patch. I guess some fiddling with the CI configuration is going to be necessary to get this PR in mergeable form. Someone will pick it up eventually if you don't get to it first.

@andreasabel
Copy link
Author

@facundominguez Yeah, I usually fix CIs, but none that involve nix because I know nothing about nix.

@ConnorBaker
Copy link
Contributor

So sorry you're running into this issue with CI! I definitely let it go too long without an update.

I've started work to fix that in #422. I hope to get it merged soon.

Depending on how much bandwidth you have, you can rebase once that happens (should mostly involve just removing the changes you had to make to CI) or I can edit it and commit for you. Let me know which you prefer!

@andreasabel
Copy link
Author

@ConnorBaker Thanks for taking up the fight with the CI.
I suppose after your PR has been merged, a maintainer can merge mine, resolving the conflicts.

@ConnorBaker
Copy link
Contributor

Closing in favor of #422 and #423.

@andreasabel would you make sure those fix the issues you found? Barring GitHub timeout errors, CI should be green for both of those PRs, including the testing on the nightly Stackage snapshot introduced in #423.

@ConnorBaker ConnorBaker closed this Feb 5, 2024
@andreasabel
Copy link
Author

@ConnorBaker thanks!

cabal build -w ghc-9.8.1 of inline-r from master went fine.
cabal test reports an error:

Test suite test-shootout: RUNNING...
During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C" 
2: Setting LC_TIME failed, using "C" 
3: Setting LC_MESSAGES failed, using "C" 
4: Setting LC_MONETARY failed, using "C" 
During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C" 
2: Setting LC_TIME failed, using "C" 
3: Setting LC_MESSAGES failed, using "C" 
4: Setting LC_MONETARY failed, using "C" 
During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C" 
2: Setting LC_TIME failed, using "C" 
3: Setting LC_MESSAGES failed, using "C" 
4: Setting LC_MONETARY failed, using "C" 
Quoted shootout programs
  tests/shootout/binarytrees.R:       During startup - Warning messages:
1: Setting LC_COLLATE failed, using "C" 
2: Setting LC_TIME failed, using "C" 
3: Setting LC_MESSAGES failed, using "C" 
4: Setting LC_MONETARY failed, using "C" 
Test suite test-shootout: FAIL

Not sure whether you want to fix this.
Anyway, once you release to Hackage you can enable inline-r in Stackage again.

@ConnorBaker
Copy link
Contributor

ConnorBaker commented Feb 6, 2024

Huh, I'm unable to reproduce on my desktop -- though I am using NixOS and ran

nix-shell ./shell-cabal.nix -I nixpkgs=nixpkgs.nix --run "cabal test all"

How are your cabal and ghc provisioned? Also, is your LANG environment variable set to anything?

EDIT: Also, what version of R do you have? That, and the version of glibc please!

@andreasabel
Copy link
Author

Have cabal and ghc (which is ghc-9.8.1) in the PATH.

$ echo $LANG

$ R --version
R version 4.3.2 (2023-10-31) -- "Eye Holes"

I am on macOS 12, not clear how to get the version of glibc there...

@ConnorBaker
Copy link
Contributor

Can you try using an older version of R, from the 4.2.x series? I think there may have been a change in 4.3.x which broke some interop.

@andreasabel
Copy link
Author

Mmh, brew does not offer a formula for [email protected] or similar, and it is a bit much hassle to do a manual install. (After all, I am not really a user of R...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants