Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix code coverage not generated for phonenumber.test project and remove old code coverage upload from appveyor #246

Merged

Conversation

wmundev
Copy link
Collaborator

@wmundev wmundev commented Apr 20, 2024

Getting a

Data collection : Unable to find a datacollector with friendly name 'XPlat Code Coverage'.
Data collection : Could not find data collector 'XPlat Code Coverage'

error because coverlet.collector not installed in PhoneNumbers.Test project

Changes

  • fix code coverage not generated for phonenumber.test project
  • remove old code coverage upload from appveyor

…d remove old code coverage upload from appveyor
@wmundev wmundev requested a review from twcclegg April 20, 2024 02:49
@wmundev wmundev self-assigned this Apr 20, 2024
Copy link
Owner

@twcclegg twcclegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers

@wmundev wmundev merged commit 0d4ed96 into twcclegg:main Apr 20, 2024
4 checks passed
@wmundev wmundev deleted the feature/remove-code-coverage-from-old-build branch April 20, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants