Add font-family support #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- First pass at adding font-family support - Requires changing width and height from 1em to 16px before running font-family script - Mounts the generated font folder in Hugo so we can build it into the docs - Moves SVG sprite into the new dist folder where the font files are now located
|
Bumping this back one more release because the dependencies used to generate this PR's font families were archived and I haven't had time to dig into things properly. Sorry folks! |
|
Closing for #515. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at generating font families, but still needs work. Generator doesn't like our use of em units in width and height, so they need to be reprocessed with pixel dimensions to work. Also requires some icon updates to remove transform attributes (coming in a separate PR).
I've also reorganized a couple things, putting the generated font files and SVG sprite into a new dist directory. The dist directory is then included in the npm package files option.
Still more to do, but a promising start for sure.
Fixes #86.