Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust alerts text color to pass WCAG 2.0 Luminance. #7366

Closed
wants to merge 1 commit into from

Conversation

AlexandrYZ
Copy link

Fixed alerts on the right side

adjusted alerts
Colour Contrast Check web utility

@archonic
Copy link

👍!!

@grahama
Copy link

grahama commented Mar 22, 2013

I feel compelled to point out the obvious.

After this commit, there is so little difference between all the alert colours (i.e. forground text) as demonstrated by your image, there is little point in actually using these alerts any more.

The flair and simplicity of these alerts is the fact that they are soft and subtle and not bold and contrasting.

The previously accepted and very widely used alert colours are clearly based on a traffic light (RGA) system which would be fairly clear using any common palette. However, on smaller palettes, these new colours will all use the same colour and thus defeat the RBA system.

Personally, I think that If someone has a requirement of WCAG 2.0 Luminance conformance, let them exercise that by overriding the base CSS.

It feels like someone just switched my TV back to "Black & White" - yes, I'm old enough to remember that!

Albert

@mdo
Copy link
Member

mdo commented Mar 24, 2013

We won't be merging this in. I'm not against ensuring there is proper contrast, but this doesn't look that good. If you wanted to try to find a balance in lightening the background and darkening the text, then we can consider that. Otherwise these kinds of changes will be punted.

@mdo mdo closed this Mar 24, 2013
@archonic
Copy link

Thanks for your work @AlexandrYZ, I'll be implementing this in my environments and my fork.

@masterbee
Copy link
Contributor

@mdo - Just wanted to reference my PR about the same topic. The colors are slightly more inline with the current defaults and pass WCAG 2.0 validation mentioned here. #11432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants