Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Change example focus order #40972

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 24, 2024

Description

Change the focus order of the examples.
Issue when the window is very small on long file names. See here the JS example on small viewports.

Motivation & Context

Better accessibility on focus order to have the content before the copy button.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@julien-deramond
Copy link
Member

I haven't reviewed the code yet, but this PR seems to bring a more logical order to the focusable elements:

  1. File (optional)
  2. Code
  3. Edit on StackBlitz (optional)
  4. Copy code

It feels more intuitive to inspect the code before attempting to copy it.

I'll wait for @patrickhlauke feedback before reviewing the actual code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

2 participants