Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add missing type="button" to Cheatsheet nav buttons #39585

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jan 15, 2024

Description

Fix a very minor issue (reported by Webhint):
https://webhint.io/docs/user-guide/hints/hint-button-type/

Motivation & Context

The default type for is submit (not type="button" as one might expect). This can lead to surprising keyboard behavior within a form. We added type="button" to all other buttons on the site - makes sense to add them here too.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@coliff coliff changed the title Add missing type="button" to Cheatsheet nav buttons Docs: Add missing type="button" to Cheatsheet nav buttons Jan 15, 2024
@julien-deramond julien-deramond merged commit 0476078 into twbs:main Jan 30, 2024
14 checks passed
@coliff coliff deleted the dev/coliff/cheatsheet-button-fix branch January 30, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants