Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating labels: fix disabled with text inside #38913

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jul 17, 2023

Description

Add a rule to add more specifity on disabled rule.
Add some text inside one of our exemple since it doesn't overlap anything and help for the support.

Motivation & Context

Asked by community

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fixes #38731.

@louismaximepiton louismaximepiton requested a review from a team as a code owner July 17, 2023 10:13
@mdo mdo merged commit cc5a8a9 into main Jul 24, 2023
@mdo mdo deleted the main-lmp-fix-disabled-floating-label branch July 24, 2023 04:41
@XhmikosR
Copy link
Member

@louismaximepiton that's why I said the other day to fix your commit messages 😛

image

@mdo
Copy link
Member

mdo commented Jul 25, 2023

Fwiw I don’t care about commit messages haha. It’s the references PRs and issues I care more about. As long as we have that, we’re usually good :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

v5.3.0 Broken floating label background for disabled Input[type=text] and textarea
3 participants