Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve Text Alignment Example #38872

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Docs: Improve Text Alignment Example #38872

merged 1 commit into from
Jul 6, 2023

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jul 6, 2023

Description

On the Text alignment example all the text is left-aligned to start with and doesn't change on any viewport change. I think it makes much more sense for it to end-aligned on certain breakpoints.

I also added a missing text-xxl-end class :-)

I didn't use dashes between the breakpoint size names to match the Breakpoints docs (https://getbootstrap.com/docs/5.3/layout/breakpoints/#available-breakpoints)

Motivation & Context

Improved UX/DX for users/developers

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

On the Text alignment example  all the text is left-aligned to start with and doesn't change on any viewport change. I think it makes much more sense for it to end-aligned on certain breakpoints.

I also added a missing `text-xxl-end` class :-)

I didn't use dashes between the breakpoint size names to match the Breakpoints docs (https://getbootstrap.com/docs/5.3/layout/breakpoints/#available-breakpoints)
@coliff coliff changed the title Improve Text Alignment Example Docs: Improve Text Alignment Example Jul 6, 2023
@mdo mdo merged commit e0d54ff into twbs:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants