-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(spinners): improve buttons examples accessibility #38632
Conversation
It will depend on a few factors, mainly how authors will implement these spinners. It would be nice to have an actual working example of a spinner that appears after a particular action, spins for a while, then disappears again, as that would then provide a good example of how authors should use it in practice (and give us something to test as well) |
* docs(spinners): improve buttons examples accessibility * docs(spinners): missed occurrence of wrong role + aria-hidden --------- Co-authored-by: Patrick H. Lauke <[email protected]>
Description
Moving the status role around to ensure it can be useful.
Motivation & Context
The button examples in spinners documentation are really weird regarding accessibility, since the status role is applied on hidden empty elements.
@patrickhlauke we may have a few sentences to add, for example mentioning how a live region works—mainly that it should already be in the DOM and only feed and shown on-demand? The current statement feels very short:
Type of changes
Checklist
npm run lint
)Live previews