Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Chart.js from 2.9.4 to 4.2.1 in dashboard examples #38071

Merged
merged 4 commits into from
Feb 19, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 16, 2023

Description

This PR suggests to bump Chart.js version in dashboard and dashboard RTL examples from 2.9.4 to 4.2.1.

The configuration has slightly changed. There's no graphical regression; just a minor change regarding the rendering of numbers on the y-axis.

Type of changes

  • Enhancement (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@XhmikosR
Copy link
Member

Nitpicking, it seems the the number in the tooltip is now too close

image

Also, what's the reason for removing the variable? We had it there so that it's explicit.

@julien-deramond
Copy link
Member Author

julien-deramond commented Feb 17, 2023

Nitpicking, it seems the the number in the tooltip is now too close

Haven't changed anything, it's the default rendering. But I can work on it to add some spacing between the color area and the text.

Also, what's the reason for removing the variable? We had it there so that it's explicit.

My bad, thought it was useless to affect it to something never used. Rollbacked it in 35b7a21.

@julien-deramond
Copy link
Member Author

Added some padding in 4f4c059. Rendering is better, thanks for pointing this out :)

@XhmikosR XhmikosR merged commit 5241b98 into main Feb 19, 2023
@XhmikosR XhmikosR deleted the main-jd-bump-chartjs-cdn-dep branch February 19, 2023 08:34
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants