Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gutters docs #37918

Merged
merged 2 commits into from
Jan 21, 2023
Merged

Update gutters docs #37918

merged 2 commits into from
Jan 21, 2023

Conversation

ChellyAhmed
Copy link
Contributor

@ChellyAhmed ChellyAhmed commented Jan 20, 2023

Description

In Bootstrap documentation, in Layout => Gutters. In the Horizontal & vertical gutters section, I changed the description from ".g-* classes can be used to control the horizontal gutter widths" to ".g-* classes can be used to control the horizontal and vertical gutter widths".

Motivation & Context

The documentation was misleading. In fact, the classes in question are used to modify horizontal and vertical gutters. However, it indicates that they only change the horizontal section. This might lead users, especially new ones, to confuse the classes "g-" with "gx-"

I thought of introducing these changes after checking issue #37914 opened by marcomarsala.

Type of changes

Documentation update

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Live preview:

https://deploy-preview-37918--twbs-bootstrap.netlify.app/docs/5.3/layout/gutters/

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly

Related issues

#37914

@mdo mdo merged commit d9d2b4f into twbs:main Jan 21, 2023
@mdo mdo mentioned this pull request Jan 22, 2023
@mahilanmjd mahilanmjd mentioned this pull request Apr 16, 2023
6 tasks
@ChellyAhmed ChellyAhmed changed the title fix typo in gutters doc Update gutters docs May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants