Add theme maps specific to dark mode #37843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft idea
/cc @mdo
This PR tries to tackle a part of the problem we currently have with the new complexity of customizing colors in Bootstrap coming with the color modes. This is also link to the complexity that we can see in #37737 (only for the dark mode) and to this answer: #37838 (reply in thread).
On one hand we have for the light mode:
On the other hande we have for the dark mode:
So this PR suggests to have an equivalent for the dark mode and so to have corresponding maps:
$theme-colors-text-dark
$theme-colors-bg-subtle-dark
$theme-colors-border-subtle-dark
TODO if this PR is useful:
IDK if it would be helpful or not but we could create a mixin to avoid copy-pasting this system; something like: