Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add CSS variables section in close button section #37782

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 2, 2023

Description

This PR adds consistency in the docs by adding in the close button page a CSS var section, as it is done for other components.

This is linked to #36457 which was merged after the release of the 5.2 so the 5.3 added-in shortcode has been added as well.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Related to #36457

@julien-deramond julien-deramond marked this pull request as ready for review January 2, 2023 07:03
@julien-deramond julien-deramond requested a review from a team as a code owner January 2, 2023 07:03
@maheshkasabe
Copy link

Seems good to merge

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mdo mdo merged commit e60002b into main Jan 2, 2023
@mdo mdo deleted the main-jd-add-css-var-section-in-btn-close-docs branch January 2, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants