Docs: handle light/dark mode in Algolia search modal #37738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR suggests some modifications to handle the dark mode in Algolia modal based on the values available in their CSS file.
I preferred to avoid adding a
data-theme="dark"to our<html>in the docs and rather copied the content of their CSS file in ours.Also moved some
--docsearch-*definitions in our_search.scssfile to gather together this management in a single file.Finally, had to add a patch because
--docsearch-logo-colordoesn't seem to work well in our case. Sounds like a bug (see algolia/docsearch#1695 where I've added a lil' comment)Motivation & Context
Simple motivation: having a light/dark mode for this modal as well.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Linked to a sub-task in #37549