Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color-scheme to dark root selector #37734

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Add color-scheme to dark root selector #37734

merged 1 commit into from
Dec 28, 2022

Conversation

mdo
Copy link
Member

@mdo mdo commented Dec 27, 2022

Unfortunately, I don't see any difference in setting this on macOS at least (Safari and Chrome). Select elements and scroll bars don't update until I change the OS level color mode.

Fixes #37710.

@mdo mdo requested a review from a team as a code owner December 27, 2022 18:33
@mdo mdo mentioned this pull request Dec 27, 2022
2 tasks
@julien-deramond
Copy link
Member

julien-deramond commented Dec 27, 2022

I can see this difference at least on macOS (Ventura 13.1)/Edge (108.0.1462.54) for now.

This PR main branch
2022-12-27 22 14 52 2022-12-27 22 14 38

@coliff
Copy link
Contributor

coliff commented Dec 28, 2022

Nice improvement with scrollbars and Autofill form state on Edge v108 on Windows 10. 👍
this PR:
image

Main:
image

@coliff
Copy link
Contributor

coliff commented Dec 28, 2022

Color Picker UI is improved too:
main:
image

This PR:
image

@julien-deramond
Copy link
Member

julien-deramond commented Dec 28, 2022

Some other improvements in our docs where we mention browser default rendering! (still Edge/macOS)

Screenshot 2022-12-28 at 09 45 39

Screenshot 2022-12-28 at 09 45 25
Screenshot 2022-12-28 at 09 43 51
Screenshot 2022-12-28 at 09 43 46

@mdo
Copy link
Member Author

mdo commented Dec 28, 2022

Awesome! Will get it merged today then :).

@mdo mdo merged commit 5d9c09c into main Dec 28, 2022
@mdo mdo deleted the color-scheme branch December 28, 2022 21:00
@XhmikosR XhmikosR changed the title Add color-scheme to dark root selector Add color-scheme to dark root selector Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add color-scheme for dark mode
3 participants