Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix "Usage -> Enable dark mode" code example #37553

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Nov 29, 2022

Description

Change 'Usage > Enable dark mode' code example to actually apply data-bs-theme="dark" to the <html> element and not the <body> element.

Motivation & Context

Coherence between the description, the code example and the actual usage in Bootstrap docs where data-bs-theme="auto" is set to the <html> element.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

Live previews

@julien-deramond julien-deramond merged commit 93c09e7 into main Nov 29, 2022
@julien-deramond julien-deramond deleted the main-jd-fix-usage-enable-dark-mode-desc branch November 29, 2022 07:38
@XhmikosR XhmikosR changed the title Docs: fix 'Usage > Enable dark mode' code example Docs: fix "Usage -> Enable dark mode" code example Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants