Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix var --bs-body-font-family. Keep quotes in the font stack. #37526

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

cdaecke
Copy link
Contributor

@cdaecke cdaecke commented Nov 21, 2022

Description

Quotes in var --bs-body-font-family are removed.

Motivation & Context

When using something like $font-family-base: "Helvetica Neue", Arial the quotes are removed, so you will get this:

:root {
    --bs-body-font-family: Helvetica Neue, Arial;
}

Expected behaviour would be:

:root {
    --bs-body-font-family: "Helvetica Neue", Arial;
}

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@cdaecke cdaecke requested a review from a team as a code owner November 21, 2022 20:25
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the time, quotes are not needed, as Mathias Bynens explained a few years ago.

However if someone needs to use quotes, we should allow it. Thanks for the PR!

@julien-deramond julien-deramond merged commit abdd3fe into twbs:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants