Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scss: Adding missing z-index CSS variables. #37021

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Scss: Adding missing z-index CSS variables. #37021

merged 1 commit into from
Sep 1, 2022

Conversation

louismaximepiton
Copy link
Member

Adding CSS variables for z-index in:

  • Dropdown
  • Offcanvas
  • Toast

@louismaximepiton louismaximepiton requested a review from a team as a code owner August 24, 2022 13:40
@louismaximepiton louismaximepiton mentioned this pull request Aug 24, 2022
Merged
julien-deramond
julien-deramond approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Consistent with what's been done in _modal.scss, _popover.scss and _tooltip.scss.

@mdo mdo merged commit a0238d1 into twbs:main Sep 1, 2022
@louismaximepiton louismaximepiton deleted the main-lmp-zindex-css-var branch September 2, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
css v5
Projects
No open projects
v5.2.1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louismaximepiton @julien-deramond @mdo