-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScrollSpy: make the threshold option configurable #36750
Conversation
85cec49
to
b5daa3f
Compare
5fa2f60
to
3896c84
Compare
4abaaed
to
b462723
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested how it works in details but the mechanism to provide the threshold
param seems to work pretty well.
Just few proposals of improvement and a question on my side.
992c2ec
to
5fd45ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Don't know if anyone want to double check this one.
5fd45ba
to
23ddc61
Compare
Co-authored-by: Julien Déramond <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
23ddc61
to
6e8ba11
Compare
ref #36431