Add missing things in hide method of dropdown
#36529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing as stale and as a won’t do. We’ll be continuing to focus all our efforts on v5.x after we ship what’s been merged into v4-dev thus far for a v4.6.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave a try to backport #33451 to v4.
Feel free to modify it directly or close it if it is too far from what's expected here.
I haven't backported the new unit test
it('should remove event listener on touch-enabled device that was added in show method', done => {because in v4 there was no existing test in that spirit. In v5 there are tests ofEventHandler.offandEventHandler.onbut not in v4.