Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bootstrap Icons to alerts docs #33690

Merged
merged 4 commits into from
Apr 25, 2021
Merged

Add Bootstrap Icons to alerts docs #33690

merged 4 commits into from
Apr 25, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented Apr 19, 2021

Adds examples of using Bootstrap Icons in the alerts component with flexbox utilities. Takes it a small step further and suggests custom SVG sprites as well just in case folks use an extensive set of alert/icon combinations.

Closes #33536, fixes #33480.

Screen Shot 2021-04-19 at 9 02 44 AM

Preview: https://deploy-preview-33690--twbs-bootstrap.netlify.app/docs/5.0/components/alerts/#icons

@XhmikosR
Copy link
Member

@mdo we could add this in 5.0.0 if you prefer.

@devhoussam
Copy link
Contributor

@mdo we could add this in 5.0.0 if you prefer.

I hope so

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat examples :)

We may want to use aria-label on SVGs to convey state too, it's been requested on Boosted but not sure it's mandatory.

site/content/docs/5.0/components/alerts.md Outdated Show resolved Hide resolved
@ffoodd
Copy link
Member

ffoodd commented Apr 20, 2021

Thanks for proofreading, @XhmikosR, my Bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V5 Alerts Component : Add the icon space
4 participants