Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change the value for altBoundary option #33684

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Conversation

rohit2sharma95
Copy link
Collaborator

Closes #33463 and
Closes #33579

Since the bootstrap is not changing the default value of the elementContext option, changing the value of the altBoundary option is not needed for any modifier in real. By default, the value for elementContext is 'popper' which means the boundary context will be checked for the popper element by default. Setting the altBoundary to true in the flip modifier will change this behavior and then boundary context will be checked for reference element (means button element).

Doing so will require setting the value for the boundary option manually. That is not needed in real (at least for the tooltips when these are appended to the body).

See the discussion here: #33463 (comment)

/CC @XhmikosR to add this in the next release if seems good.

- Since bootstrap is not changing the default value of `elementContext`
  option, changing the value of `altBoundary` option is not needed for
any modifier in real
@alpadev
Copy link
Contributor

alpadev commented Apr 19, 2021

I had a feeling this would be the reason but I wasn't sure still. 😅 I got a bit confused by what all those options really do and how they influence each other and what if you change it on one module but not on the other.
Thanks for explaining this in more detail @rohit2sharma95 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants