-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Enable 0.x
with negative margins @ v4
#33593
Conversation
I set it as below, but no negative margin was added. `$spacers: (0\.5: ($spacer * .125));` After investigating, it seems that `0 \ .5` is also evaluated as 0. So I changed it to string comparison. HTML example: `<img class="mt-n0.5">`
Is this needed in |
Maybe not. v5 codes
-- NOTE: v5 dist css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this. Any objections @twbs/css-review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, never thought about such values 👌
I set it as below, but no negative margin was added.
$spacers: (0\.5: ($spacer * .125));
After investigating, it seems that
0 \ .5
is also evaluated as 0.So I changed it to string comparison.
HTML example:
<img class="mt-n0.5">