Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Enable 0.x with negative margins @ v4 #33593

Merged
merged 4 commits into from
Jun 24, 2021
Merged

🐛 Enable 0.x with negative margins @ v4 #33593

merged 4 commits into from
Jun 24, 2021

Conversation

k-utsumi
Copy link
Contributor

@k-utsumi k-utsumi commented Apr 9, 2021

I set it as below, but no negative margin was added.
$spacers: (0\.5: ($spacer * .125));

After investigating, it seems that 0 \ .5 is also evaluated as 0.
So I changed it to string comparison.

HTML example: <img class="mt-n0.5">

I set it as below, but no negative margin was added.
`$spacers: (0\.5: ($spacer * .125));`

After investigating, it seems that `0 \ .5` is also evaluated as 0.
So I changed it to string comparison.

HTML example: `<img class="mt-n0.5">`
@k-utsumi k-utsumi requested a review from a team as a code owner April 9, 2021 08:50
@mdo mdo added the css label Apr 9, 2021
@mdo
Copy link
Member

mdo commented Apr 9, 2021

Is this needed in main for v5 as well?

@mdo mdo added the v4 label Apr 14, 2021
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. Any objections @twbs/css-review?

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, never thought about such values 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants