Dropdown — Drop flip option
#33198
Merged
Dropdown — Drop flip option
#33198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33181
Since this option is not working already, dropping it should not be a breaking change IMO.
Not adding the
fallbackPlacementshere in place of theflipoption because the Popper's default value for this option is not customized by Bootstrap. Bootstrap is not customizing the value forfallbackPlacementsbecause it is not needed: #32843. Users can change the flipping behavior by passing the array in thefallbackPlacementsoption directly in Popper's config. (For example, flipping behavior can be disabled by passing an empty array to thefallbackPlacementsoption.)