Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar link color contrast #30034

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Navbar link color contrast #30034

merged 1 commit into from
Jan 17, 2020

Conversation

jorimvanhove
Copy link
Contributor

@jorimvanhove jorimvanhove commented Jan 17, 2020 •
edited
Loading

Closes #30012

@jorimvanhove jorimvanhove requested a review from a team as a code owner January 17, 2020 08:38
MartijnCuppens
MartijnCuppens approved these changes Jan 17, 2020
View reviewed changes
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should do the job indeed:

@XhmikosR
Copy link
Member

LGTM, thanks. BTW I wonder if this was flagged in #29315?

@MartijnCuppens
Copy link
Member

It's a semi-transparent color, not sure if pa11y-ci supports this?

@MartijnCuppens MartijnCuppens changed the title Elements must have sufficient color contrast Navbar link color contrast Jan 17, 2020
@MartijnCuppens MartijnCuppens merged commit af78de3 into twbs:master Jan 17, 2020
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@jorimvanhove @olsza
Navbar link color contrast (twbs#30034)
8ad665f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check navbar color contrast
3 participants
@jorimvanhove @XhmikosR @MartijnCuppens