Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent text decoration skip ink and reorder comments #27673

Merged
merged 3 commits into from
Nov 18, 2018
Merged

Prevent text decoration skip ink and reorder comments #27673

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ddee45
Prevent text decoration skip inc and reorder comments
MartijnCuppens Nov 15, 2018
24f2888
Merge branch 'v4-dev' into v4-dev-martijncuppens-fix-abbr
XhmikosR Nov 16, 2018
1a00717
Merge branch 'v4-dev' into v4-dev-martijncuppens-fix-abbr
XhmikosR Nov 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions scss/_reboot.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,17 +111,19 @@ p {

// Abbreviations
//
// 1. Remove the bottom border in Firefox 39-.
// 1. Duplicate behavior to the data-* attribute for our tooltip plugin
// 2. Add the correct text decoration in Chrome, Edge, IE, Opera, and Safari.
// 3. Add explicit cursor to indicate changed behavior.
// 4. Duplicate behavior to the data-* attribute for our tooltip plugin
// 4. Remove the bottom border in Firefox 39-.
// 5. Prevent the text-decoration to be skipped.

abbr[title],
abbr[data-original-title] { // 4
abbr[data-original-title] { // 1
text-decoration: underline; // 2
text-decoration: underline dotted; // 2
cursor: help; // 3
border-bottom: 0; // 1
border-bottom: 0; // 4
text-decoration-skip-ink: none; // 5
}

address {
Expand Down