refactor spinners SCSS #27655
Closed
refactor spinners SCSS #27655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnCuppens
requested changes
Nov 12, 2018
| width: $spinner-width-sm; | ||
| height: $spinner-height-sm; | ||
| border-width: $spinner-border-width-sm; | ||
| &.spinner-sm { |
There was a problem hiding this comment.
I would not use the & here, we don't do that for other modifiers, eg .btn-lg:
Line 110 in d96c147
There was a problem hiding this comment.
Also, the class is not correct
| } | ||
|
|
||
| .spinner-border { | ||
| %spinner { |
There was a problem hiding this comment.
Watch out with extends, you idea was probably to generate less code, but with this technique, you've added 2 extra selectors. I would prefer to see a mixin instead, but don't know if @mdo also agrees?
|
I left a reply to your comment in #22960 about this—we won't be changing to an extend based approach as it adds more selectors. Plus, you've changed the selectors here, which are fine as-is with the base class and modifier classes approach. Thanks though :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
latest SCSS code from #22960 did not work for me on spinner
-smclasses.So I went along and refactored a little bit:
%spinnerwhichspinner-borderandspinner-growboth extendspinner-smmodifier class which is used in combination withspinner-borderandspinner-growto make small spinners, this is the way bootstrap treats other classes as well@keyframesto save more byteAny feedback is heavily welcome.
Have a nice weekend (or start in the week)
midzer