Fix modal positioning on Android #27592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
XhmikosR
force-pushed
the
v4-dev-martijncuppens-android-modal-fix
branch
from
3c2f591
to
fbffdc1
Compare
XhmikosR
approved these changes
Nov 4, 2018
When the address bar is hidden, sometimes the visual position of the controls is out of sync with its logical position.
XhmikosR
force-pushed
the
v4-dev-martijncuppens-android-modal-fix
branch
from
fbffdc1
to
9c6ab53
Compare
XhmikosR
changed the title
mdo
approved these changes
Nov 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #26811 due to a branch mix-up
Fixes #26811