Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-group): Support form-control-plaintext as a sibling #27579

Closed
wants to merge 1 commit into from

Conversation

tmorehouse
Copy link
Contributor

PR #25871 added support for .form-control-plaintext inside an input-group (addressing issue #25870), but it did not include handling the situation of multiple inputs in the same input group (where .form-control-plaintext is not the first input).

This PR adds in the missing line to handle this situation.

PR twbs#25871 added support for `.form-control-plaintext` inside an input-group (addressing issue twbs#25870), but it did not include handling the situation of multiple inputs in the same input group (where `.form-control-plaintext` is not the first input).

This PR adds in the missing line to handle this situation.
@tmorehouse tmorehouse requested a review from a team as a code owner November 2, 2018 12:56
@tmorehouse
Copy link
Contributor Author

tmorehouse commented Nov 2, 2018

Hmmm now that I look at this, I just realized that .form-control-plaintext inside an input group doesn't have a border (so maybe this PR is not needed). Should borders be added to it when it is inside an input-group for consistent look with other input-groups or should it be left borderless?

And also noticed that .form-control-plaintext is missing the left and right padding (to line it's contents up with other controls that may be in the same form) when inside an input-group.

@MartijnCuppens
Copy link
Member

No need for this PR, you can use the readonly attribute for this as mdo mentioned #25870 (comment)

@tmorehouse
Copy link
Contributor Author

@MartijnCuppens that is a good point re readonly. I wonder if that suggestion should be mentioned in the input group documentation?

@tmorehouse tmorehouse deleted the patch-1 branch November 2, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants