Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boom toasted #27155

Merged
merged 5 commits into from
Aug 31, 2018
Merged

Boom toasted #27155

merged 5 commits into from
Aug 31, 2018

Commits on Aug 30, 2018

  1. - add more information about accessibility requirement on toast compo… 

    …nents

- implement data-dismiss="toast" to easily create a non-autohide toast and allow user to interact itself with the component
    @Lausselloic
    Lausselloic committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    e9a04a2 View commit details
    Browse the repository at this point in the history

  2. add a close button to visual test and move to a close function the re… 

    …al close actions. By this way could be call when user click on close button
    @Lausselloic
    Lausselloic committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    9adca75 View commit details
    Browse the repository at this point in the history

  3. attach click event listener onto close component outside of the compl… 

    …ete method otherwise shown event is thrown before event is attached.

Also add a param to hide method, if withoutTimeout=true then don't set the timeout and call close. Otherwise call close after the timeout
    @Lausselloic
    Lausselloic committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    095cfed View commit details
    Browse the repository at this point in the history

  4. apply accessibility recommendation on the sample components

    @Lausselloic
    Lausselloic committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    58a999f View commit details
    Browse the repository at this point in the history

  5. move close method as private, create a private method to setlisteners… 

    …, and attach listeners in constructor
    @Lausselloic
    Lausselloic committed Aug 30, 2018
    Configuration menu
    Copy the full SHA
    3f1bb51 View commit details
    Browse the repository at this point in the history