Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to BrowserStack #27007

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Move to BrowserStack #27007

merged 1 commit into from
Aug 30, 2018

Conversation

Johann-S
Copy link
Member

@Johann-S Johann-S commented Aug 1, 2018

Related to our internal discussion about moving away from Sauce Labs to BrowserStack

@Johann-S Johann-S requested a review from XhmikosR August 1, 2018 08:16
@Johann-S Johann-S force-pushed the v4-dev-jo-browserstack branch 5 times, most recently from 239bad5 to 09e3d6d Compare August 2, 2018 13:27
@Johann-S Johann-S force-pushed the v4-dev-jo-browserstack branch 2 times, most recently from 66dc559 to a301f7d Compare August 28, 2018 08:39
@Johann-S
Copy link
Member Author

@XhmikosR it's up to date 😉
You can provide to BrowserStack this URL (which contain their logo): https://github.com/twbs/bootstrap/tree/v4-dev-jo-browserstack

@XhmikosR
Copy link
Member

Thanks, I'll adapt the docs

@Johann-S
Copy link
Member Author

I have to add the BrowserStack badge

@XhmikosR
Copy link
Member

Ok, so tests are up and running on BrowserStack. We need to fix a couple of issues we have and we make the switch.

@XhmikosR XhmikosR changed the title move away from sauce labs to browserstack Move to BrowserStack Aug 28, 2018
@Johann-S Johann-S force-pushed the v4-dev-jo-browserstack branch 8 times, most recently from e5027bd to 1ad4e86 Compare August 30, 2018 15:12
@Johann-S
Copy link
Member Author

@XhmikosR everything is done and works well, do you want to review a last time ?

@XhmikosR
Copy link
Member

XhmikosR commented Aug 30, 2018

I'm thinking, don't remove the Sauce Labs Travis vars yet because some PRs might be behind the main branch and use that. But it's your call.

@Johann-S
Copy link
Member Author

You're right, I'll wait a bit before removing Sauce Labs var

@Johann-S Johann-S merged commit 54d86e6 into v4-dev Aug 30, 2018
@Johann-S Johann-S deleted the v4-dev-jo-browserstack branch August 30, 2018 20:17
@mdo mdo mentioned this pull request Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants