Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new docs Versions page #26989

Merged
merged 1 commit into from
Sep 2, 2018
Merged

Add new docs Versions page #26989

merged 1 commit into from
Sep 2, 2018

Conversation

mdo
Copy link
Member

@mdo mdo commented Jul 29, 2018

screen shot 2018-07-29 at 3 45 41 pm

Fixes #26883.

@sts-ryan-holton
Copy link
Contributor

Looks Good!

@XhmikosR
Copy link
Member

XhmikosR commented Aug 2, 2018

Tests seem to fail.

@XhmikosR
Copy link
Member

@mdo: is this ready from your side?

@mdo mdo merged commit 97801a7 into v4-dev Sep 2, 2018
@mdo
Copy link
Member Author

mdo commented Sep 2, 2018

@XhmikosR Thanks for the squash and the ping! <3

@mdo mdo deleted the docs-versions branch September 2, 2018 20:57
@mdo mdo mentioned this pull request Sep 2, 2018
@XhmikosR
Copy link
Member

XhmikosR commented Oct 13, 2018

@mdo: shouldn't the link here be {{ site.baseurl }}/docs/versions/? Or you plan to move this to the root? I just have a feeling this isn't right.

@mdo
Copy link
Member Author

mdo commented Oct 13, 2018

@XhmikosR If can be that. I was copy-pasting stuff across multiple versions and was being lazy with the hard coding.

@XhmikosR
Copy link
Member

All right, I thought so too. I added a patch in #27408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants