-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with normalize 8.0.0 #26296
Merged
Merged
Sync with normalize 8.0.0 #26296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Apr 16, 2018
@Varunram: can you rebase please? |
Thanks! Will do shortly. |
diff credits: @client9
should be good now :) |
XhmikosR
changed the title
Resolve #26226: Sync with normalize 8.0.0
Sync with normalize 8.0.0
Oct 28, 2018
I think we can also remove this: Lines 43 to 47 in 5aed968
But keep the main , see necolas/normalize.css@004d58b#diff-bb3dde41d97f19be8ab7b4780a915d5e
|
We still sort of support Android 4.4. So perhaps we should add a TODO comment to remove that in v5. |
mdo
approved these changes
Nov 3, 2018
Shall we add the TODO then? |
You can add it if you want @MartijnCuppens. |
MartijnCuppens
approved these changes
Nov 3, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diff credits: @client9
Fixes #26226