Rewrite custom file input #25068
Merged
Rewrite custom file input #25068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mdo
commented
Dec 24, 2017
mdo
commented
- Changes the wrapping label to a div so we can style the label instead of another element while also supporting form validation.
- Fixes form validation styles for custom file input (closes Invalid feedback doesn't show up after file input #24831).
- Updates docs with validation styles (also adding example feedback text while I was there) and new how it works section.
- Changes the wrapping label to a div so we can style the label instead of another element while also supporting form validation. - Fixes form validation styles for custom file input (closes #24831). - Updates docs with validation styles (also adding example feedback text while I was there) and new how it works section.
Closed
ysds
added a commit
to ysds/bootstrap
that referenced
this pull request
Dec 29, 2017
mdo
pushed a commit
that referenced
this pull request
Dec 31, 2017
gijsbotje
added a commit
to gijsbotje/bootstrap
that referenced
this pull request
Dec 31, 2017
* dist * Outline active focus (twbs#25145) * Base the outline button :active color on the background, fixing a contrast issue * Only apply focus outline to active when it's focused * Add modal-dialog-centered class to vertically centered modal example. * removes hardcoded value for nav-link padding * Apply of twbs#25068 to input group * dist * docs: Fix overflow issue in IE. (twbs#25142) * Allow nested structure for accordions (twbs#25121) This commit allows nested structures for accordions. Also a part of the documentation about data-children is removed because this functionality didn't work and it's not applicable anymore. Tests with the collapse accordion are also a bit adjusted to the new situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.