Clean up the reset code for button's rounded corners in button group and input button #24696
Conversation
- Use last-of-type selector instead of dropdown-toggle - Remove `border-raduis :0` because it is enough by each reset of the left and right side
|
Hi @ysds Thanks for the PR. I found that there is still a rounded corner on the last btn before the drop menu. Look a the first example under "nesting":
It's really challenging to remove or simplify code, thanks a lot for giving it a try. |
|
Hi @andresgalante Thank you for your review! and sorry for my insufficient check. Using |
| } | ||
|
|
||
| // Custom edits for including btn-groups within btn-groups (useful for including | ||
| // Alignment for including btn-groups within btn-groups (useful for including | ||
| // dropdown buttons within a btn-group) | ||
| > .btn-group { | ||
| float: left; |
There was a problem hiding this comment.
Do we actually need this float here? What is it for?
|
I updated the comment more concisely.
I think so too. it will not be needed. and there seems to be some other code that can be deleted/clean-up. e.g: L47- .btn-group {
> .btn:first-child {
margin-left: 0;
}and more. I can additional cleanup with another PR if this PR is approved. Thanks. |
|
Changes to the input group here will need to be removed once #25020 lands. |
|
Please follow #25073 😄 |
A
.dropdown-toggleselector is used to reset a button's rounded corner in button group and input button. But should not use adropdown-toggleselector to reset it, becausedropdown-toggledoes not have rounded corners by default.This PR including the follwings:
last-of-typeselector instead of.dropdown-toggleborder-raduis :0because it is enough by each reset of the left and right sideI hope that this PR will help improve code. Thanks.