Dropdown - refine handling of keydown in input and textarea thanks to @pvdlg #24557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
because I was lazy to pull his repository and update his branch but I let him the credits by adding his name on the commit message and on my PR |
|
Still, he should be the author. Don't get me wrong, but we need to give credit where credit's due. I can do it if you want. |
Johann-S
force-pushed
the
v4-dev-johann-dropdown-keydown-input
branch
4 times, most recently
from
2cbf004 to
40bafe7
Compare
XhmikosR
force-pushed
the
v4-dev-johann-dropdown-keydown-input
branch
from
40bafe7 to
d2bdfbb
Compare
XhmikosR
approved these changes
Oct 27, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add changes from this PR #21802 and avoid to modify our old unit tests by adding new ones, plus it fix the errors.
Again it's thanks to @pvdlg 👍
Fixes : #21366