Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jekyll ignores. #24101

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Update Jekyll ignores. #24101

merged 1 commit into from
Sep 26, 2017

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Sep 26, 2017

  • ignore twbsconfig.yml
  • add a trailing slash for folders

@XhmikosR XhmikosR requested a review from Johann-S September 26, 2017 08:06
@XhmikosR
Copy link
Member Author

Nvm, we need the JS vendor folder for jquery etc. So I think we should remove the ignore since it doesn't have any effect either.

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-update-jekyll-ignores branch from 83e2955 to 4285bdc Compare September 26, 2017 08:13
@Johann-S
Copy link
Member

You have a strange error : https://travis-ci.org/twbs/bootstrap/jobs/279852960#L635

@XhmikosR
Copy link
Member Author

Yeah, I don't know why this happens on Travis; locally everything is fine...

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-update-jekyll-ignores branch from 7956e67 to 172ea59 Compare September 26, 2017 08:41
* ignore `twbsconfig.yml`
* add a trailing slash for folders
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-update-jekyll-ignores branch from 172ea59 to 7c1ec63 Compare September 26, 2017 08:45
@XhmikosR
Copy link
Member Author

Should be fine now.

@XhmikosR XhmikosR merged commit 537651c into v4-dev Sep 26, 2017
@XhmikosR XhmikosR deleted the v4-dev-xmr-update-jekyll-ignores branch September 26, 2017 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants