v4: Remove the confusing _custom.scss file #22821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue: #17322. Original PR: #18398.
Honestly, this one is more pain than it's worth. Looking back, the file was originally added because I had left a comment in the variables file that you could copy-pasta some lines into that file for easier customization. I don't think that's a helpful way forward for a few reason:
$my-new-var: $blue
.Nuking it in favor of relying on imports from package manager directories (where you're most likely to be using source Sass files) and manual forks of the project.