v4: Rewrite progress component without <progress> element #21473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- <progress> element didn't allow animation, labels overlaid, multiple bars, etc. - Revamps CSS to use something more similar to v3's implementation - Ditches variant mixin for `bg-` utils - Rebuilds docs to match, including adding a new Height section for customizing that. Only potential remaining todo is adding `.sr-only` instances to within the bar. Unsure if that's necessary.
Quy
reviewed
Dec 30, 2016
| - The `.progress-bar` requires an inline style or custom CSS to set their width. | ||
| - The `.progress-bar` also requires some `role` and `aria` attributes to make it accessible. | ||
|
|
||
| Put that all together, and you have the following examples. |
There was a problem hiding this comment.
Maybe use the width utilities w-25, w-50, w-75 and w-100 for one of the examples.
This was referenced Dec 31, 2016
Closed
Closed
This was referenced Jan 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the entire
.progresscomponent to solve a number of issues with the<progress>element.<progress>elements don't allow animation, cannot have labels overlaid, don't support multiple bars, etc.Here's what's changes:
.bg-utils.Fixes #17148, fixes #18835, closes #18812, and helps with #21472.
Only potential remaining todo is adding
.sr-onlyinstances to within the bar. Unsure if that's necessary. Thoughts on that @patrickhlauke? Feel like looking at the aria labels we should be able to avoid that, but maybe not?