Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Miscellaneous color changes #21199

Merged
merged 3 commits into from
Nov 26, 2016
Merged

v4: Miscellaneous color changes #21199

merged 3 commits into from
Nov 26, 2016

Conversation

mdo
Copy link
Member

@mdo mdo commented Nov 25, 2016

This branch addresses a handful of color changes and contrast improvements. It doesn't solve everything from #19693, but I'm okay with that since the $brand- color changes aren't very good looking to me. We'll deal with that later.

  • Darkens the close icon colors via opacity changes.
  • Fixes $gray-light color inaccessible on white background #20952 by darkening the $gray-light value.
  • In concert with the above fix, darkened $gray and $gray-dark to keep the color scheme intact.
  • Darken the opacity of text in active list group items.

/cc @patrickhlauke

@Francismori7
Copy link

Sadly I did prefer the brand colors in #19693, they were more vibrant to the eye on my screens.

@mdo
Copy link
Member Author

mdo commented Nov 25, 2016

@Francismori7 I'm not saying we won't have changes to those colors; just not those exact values at this particular moment in time :).

@Francismori7
Copy link

@mdo don't worry about it!

@mdo mdo merged commit 76907b8 into v4-dev Nov 26, 2016
@mdo mdo deleted the v4-colors branch November 26, 2016 00:03
@mdo mdo mentioned this pull request Nov 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants