Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container to tooltip options #20725

Closed
wants to merge 1 commit into from
Closed

Add container to tooltip options #20725

wants to merge 1 commit into from

Conversation

andyexeter
Copy link
Contributor

Fixes #17755 by adding the already documented container option for tooltips and popovers.

@andyexeter
Copy link
Contributor Author

Looks like this is failing because an element is being passed as an option in one of the tests. The documentation states that the container option type should be a string or boolean. Should I update the test or update the docs/code so an element is accepted?

@andyexeter
Copy link
Contributor Author

Should be noted here as well as in #17755 that the container option will only work for elements which are position: static - otherwise Tether moves the popover/tooltip into the body. Should I update the docs to mention this?

@mdo
Copy link
Member

mdo commented Nov 26, 2016

@bardiharborow @Johann-S Any chance one of y'all could review this? <3

@bardiharborow
Copy link
Member

bardiharborow commented Nov 26, 2016

@mdo, I've made a few changes in 0ded703, including fixing the build error and switching to const to be compliant with the new linting rules.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Nov 27, 2016
@mdo
Copy link
Member

mdo commented Nov 27, 2016

Added in 87a0749.

@mdo mdo closed this Nov 27, 2016
@mdo mdo mentioned this pull request Nov 27, 2016
adrianjost added a commit to hpi-schul-cloud/schulcloud-client that referenced this pull request Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants