Fix .embed-responsive class in flex container #19739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox have trouble displaying
.embed-responsive
in aflex
container. Firefox developer said that Firefox has the correct implementation, and other browsers which show.embed-responsive
normally were wrong.This RP fixes the problem regardless of browsers' implementation by move padding into pseudo class
::before
, as the padding in pseudo class will be resolved against block.embed-responsive
instead of flex parent.Spec: http://dev.w3.org/csswg/css-flexbox/#item-margins
Safari / WebKit: https://bugs.webkit.org/show_bug.cgi?id=113519
Chrome / Blink: https://bugs.chromium.org/p/chromium/issues/detail?id=229568
Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=958714