Button toggling - trigger change event on input #18900
Merged
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please exclude dist file changes |
vlastikcz
force-pushed
the
v4-dev-buttonChange
branch
from
e47474e
to
ebf4140
Compare
|
@wolfy1339 done |
Bootstrap’s .button styles can be applied to other elements, such as labels, to provide checkbox or radio style button toggling. When the checkbox or radio state is changed, there should be triggered the change event. Currently, the change event is triggered on the Button, which is not correct. Only input fields do support the change event.
vlastikcz
force-pushed
the
v4-dev-buttonChange
branch
from
ebf4140
to
866e99b
Compare
|
are there any other issues with the Pull Request? |
This was referenced Nov 26, 2016
Closed
|
Hey there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap’s .button styles can be applied to other elements, such as labels, to provide checkbox or radio style button toggling.
And when the checkbox or radio state is changed, there should be triggered
the change event. Currently, the change event is triggered on the Button, which is not correct. Only input fields do support the change event.